One of the format strings for date in Finnish locale is currently: %a %Bn %e. %H:%M:%S %Z %Y This is not exactly wrong, but it is a very unusual format, which IMO can't be used in this kind of context. After discussing about this with a couple of people, we decided that the best format would probably be: %a %-d.%-m.%Y %T %z I would like to see this being fixed.
I asked for feedback for earlier contributors for the fi_FI locale, and got this reply: From: Tommi.Vainikainen@iki.fi Subject: Re: Date format for Finnish fi_FI locale To: Petter Reinholdtsen <pere@hungry.com> Date: Sun, 31 Oct 2004 22:30:05 +0200 On 2004-10-31T17:45:08+0200, pere@hungry.com wrote: > You get this email because you contributed to the glibc locale for > Finnish in the past. Recently, a change request for the fi_FI locale > was submitted to the glibc bugzilla, > <URL:http://sources.redhat.com/bugzilla/show_bug.cgi?id=297>. I didn't bother to register to Bugzilla, but after reading this Bugzilla report, I can confirm that it looks good, a much better format for dates than what is currently used. -- Tommi Vainikainen
I agree with this format. '%a %Bn %e. %H:%M:%S %Z %Y' is quite unusual for Finnish and though it is possible to read it correctly it requires more effort than the proposed '%a %-d.%-m.%Y %T %z' For any Finnish people who might want to chime in but would like examples: original: ke marraskuun 3. 12:01:26 EET 2004 proposed: ke 3.11.2004 12:01:45 +0200
Created attachment 367 [details] Patch to fix date_fmt for fi_FI If I understand correctly, you want to change date_fmt for fi_FI like this: --- fi_FI 31 Oct 2004 23:42:26 -0000 1.18 +++ fi_FI 14 Jan 2005 18:24:50 -0000 @@ -2188,9 +2188,8 @@ d_fmt "%d.%<U t_fmt "%T" am_pm "";"" t_fmt_ampm "" -date_fmt "%a %Bn %/ -e. %H:%M:%/ -S %Z %Y" +date_fmt "%a %-d.%\ +-m.%Y %T %z" first_weekday 2 % Monday first_workday 2 % Monday END LC_TIME The attached patch will do this change.
Obs. I just noticed. The trailing \ should be changed to / in the patch.
Yes, looks good.
Applied to CVS trunk.