Bug 2312 - Built failure when CONFIG_MODULES disabled
Summary: Built failure when CONFIG_MODULES disabled
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: kprobes (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Anil S Keshavamurthy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-09 17:45 UTC by Anil S Keshavamurthy
Modified: 2006-10-12 11:45 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments
Making CONFIG_KPROBES depends on CONFIG_MODULES (528 bytes, patch)
2006-02-09 19:45 UTC, Anil S Keshavamurthy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anil S Keshavamurthy 2006-02-09 17:45:27 UTC
[....]
  LD      init/built-in.o
  LD      .tmp_vmlinux1
kernel/built-in.o(.kprobes.text+0xa3): In function `get_insn_slot':
: undefined reference to `module_alloc'
kernel/built-in.o(.kprobes.text+0x1f3): In function `free_insn_slot':
: undefined reference to `module_free'
----------------------------------------

module_alloc() and module_free() functions are only compiled in when 
CONFIG_MODULES are enabled. So if CONFIG_MODULES are disabled we get the above 
compile error while building the kernel.

Solution: Since Kprobes is of no use if CONFIG_MODULES are disabled, so 
make CONFIG_KPROBES depends on CONFIG_MODULES and we will not have above 
compile problem.
Comment 1 Anil S Keshavamurthy 2006-02-09 19:45:54 UTC
Created attachment 862 [details]
Making CONFIG_KPROBES depends on CONFIG_MODULES

As per Ananth's suggestion, I am making kprobes depend on CONFIG_MODULES.

Please let me know if this is Okay.
Comment 2 Ananth Mavinakayanahalli 2006-02-10 07:57:30 UTC
Looks good go me!
Comment 3 Ananth Mavinakayanahalli 2006-10-12 11:45:00 UTC
This fix is in the mainline... closing