Bug 21367 - Conflict between net/if.h and linux/if.h
Summary: Conflict between net/if.h and linux/if.h
Status: NEW
Alias: None
Product: glibc
Classification: Unclassified
Component: network (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Carlos O'Donell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-09 20:07 UTC by Aurelien Jarno
Modified: 2018-04-03 19:59 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aurelien Jarno 2017-04-09 20:07:32 UTC
<net/if.h> and <linux/if.h> can't be included from the same file without causing redeclaration of enums and structs. The case where <net/if.h> is included first has already been fixed on the Linux side in commit 4a91cb61bb995. The reverse case has to be fixed on the GNU libc side.

Patch will follow on the mailing list.
Comment 1 Carlos O'Donell 2017-05-02 12:04:38 UTC
I have fixes and test cases for this.
Comment 2 Jose E. Marchesi 2018-04-03 11:06:23 UTC
Hi Carlos, Aurelien.

We are being bitten by this.  I see there was an attempt by Aurelien to address this in the glibc side: http://patchwork.ozlabs.org/patch/748776/

I couln't find Carlos's patches in libc-alpha nor git though.  Any chance these will be made available?  Otherwise we will look to fix it.

TIA!
Comment 3 Carlos O'Donell 2018-04-03 16:54:19 UTC
(In reply to Jose E. Marchesi from comment #2)
> Hi Carlos, Aurelien.
> 
> We are being bitten by this.  I see there was an attempt by Aurelien to
> address this in the glibc side: http://patchwork.ozlabs.org/patch/748776/
> 
> I couln't find Carlos's patches in libc-alpha nor git though.  Any chance
> these will be made available?  Otherwise we will look to fix it.

I have patches. I'm going to prep them right now and send another WIP to the list and TO: you, and let you move them forward. Give me an hour.
Comment 4 Carlos O'Donell 2018-04-03 17:18:47 UTC
(In reply to Carlos O'Donell from comment #3)
> (In reply to Jose E. Marchesi from comment #2)
> > Hi Carlos, Aurelien.
> > 
> > We are being bitten by this.  I see there was an attempt by Aurelien to
> > address this in the glibc side: http://patchwork.ozlabs.org/patch/748776/
> > 
> > I couln't find Carlos's patches in libc-alpha nor git though.  Any chance
> > these will be made available?  Otherwise we will look to fix it.
> 
> I have patches. I'm going to prep them right now and send another WIP to the
> list and TO: you, and let you move them forward. Give me an hour.

Posted:
https://www.sourceware.org/ml/libc-alpha/2018-04/msg00067.html
Comment 5 Jose E. Marchesi 2018-04-03 19:59:10 UTC
    --- Comment #3 from Carlos O'Donell <carlos at redhat dot com> ---
    (In reply to Jose E. Marchesi from comment #2)
    > Hi Carlos, Aurelien.
    > 
    > We are being bitten by this.  I see there was an attempt by Aurelien to
    > address this in the glibc side: http://patchwork.ozlabs.org/patch/748776/
    > 
    > I couln't find Carlos's patches in libc-alpha nor git though.  Any chance
    > these will be made available?  Otherwise we will look to fix it.
    
    I have patches. I'm going to prep them right now and send another WIP to the
    list and TO: you, and let you move them forward. Give me an hour.

Saw it, thank you!