Bug 14661 - "make check" relies on C-locale output from readelf
Summary: "make check" relies on C-locale output from readelf
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: build (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 18:04 UTC by Jonathan Nieder
Modified: 2014-06-17 04:11 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-

Attachments
nptl_db/Makefile: force C locale when running readelf (751 bytes, patch)
2012-10-03 18:13 UTC, Jonathan Nieder 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Nieder 2012-10-03 18:04:02 UTC 
In the same spirit as bug 14660:

 $ make check
[...]
 make[2] : on entre dans le répertoire « [...]/nptl_db »
 diff -p -U 0 ../sysdeps/unix/sysv/linux/x86_64/64/nptl/libthread_db.abilist [...]/build/nptl_db/libthread_db.symlist
 readelf -W -s [...]/build/nptl/libpthread.so | gawk -f [...]/build/nptl_db/db-symbols.v.i > [...]/build/nptl_db/db-symbols.out
 make[2]: *** [[...]/build/nptl_db/db-symbols.out] Erreur 1
 $ $ head nptl_db/db-symbols.out 
 _thread_db_pthread_eventbuf_eventmask_event_bits ***MISSING***
 _thread_db_pthread_start_routine ***MISSING***
 _thread_db_sizeof_list_t ***MISSING***
 _thread_db_pthread_schedparam_sched_priority ***MISSING***
 _thread_db_td_eventbuf_t_eventdata ***MISSING***
 _thread_db_list_t_prev ***MISSING***
 _thread_db_pthread_cancelhandling ***MISSING***
 _thread_db___pthread_keys ***MISSING***
 __nptl_create_event ***MISSING***
 _thread_db_sizeof_pthread ***MISSING***
Comment 1 Jonathan Nieder 2012-10-03 18:13:29 UTC 
Created attachment 6664 [details]
nptl_db/Makefile: force C locale when running readelf

This patch
Comment 2 Jonathan Nieder 2012-10-03 18:14:53 UTC 
Hit submit too early, sorry. With the attached patch applied, the db-symbols test passes for me.
Comment 3 Andreas Jaeger 2012-10-04 12:55:12 UTC 
The patch looks fine. Could you send it to libc-alpha so that somebody else commits it, please?

I suggest the following change:
* Send the changelog entry as plain text, not as a diff

Thanks!
Comment 4 Jonathan Nieder 2012-10-08 21:19:17 UTC 
commit 72bd2088
Author: Jonathan Nieder <jrnieder@gmail.com>
Date:   Mon Oct 8 14:04:23 2012 -0700

    nptl_db/Makefile: force C locale when running readelf