Bug 14361 - Sanitise CFLAGS before running autoconf-*.c tests
Summary: Sanitise CFLAGS before running autoconf-*.c tests
Status: NEW
Alias: None
Product: systemtap
Classification: Unclassified
Component: runtime (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 19:55 UTC by Philip Withnall
Modified: 2012-07-12 20:07 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Withnall 2012-07-12 19:55:51 UTC 
If the user has something like -Werror in CFLAGS in their environment, and runs stap, that -Werror flag will leak into the command line for compiling stap’s runtime autoconf-*.c programs. It can cause compilation of the tests to fail when it shouldn’t, which results in the user having the wrong config for building the kernel module to run their tapset.

I’m not sure whether stap should remove the user’s CFLAGS entirely when running the autoconf tests, or just remove obviously-bad settings like -Werror.
Comment 1 Frank Ch. Eigler 2012-07-12 20:07:31 UTC 
This could be similar to bug #14168, and clean up more kbuild-sensitive variables.