Bug 12476 - mingw target should reference windows.h instead of Windows.h
Summary: mingw target should reference windows.h instead of Windows.h
Status: RESOLVED FIXED
Alias: None
Product: binutils
Classification: Unclassified
Component: ld (show other bugs)
Version: 2.22
: P2 critical
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-09 03:16 UTC by Dongsheng Song
Modified: 2011-04-06 07:55 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Here is the patch (969 bytes, application/octet-stream)
2011-02-09 03:16 UTC, Dongsheng Song 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongsheng Song 2011-02-09 03:16:11 UTC 
Created attachment 5233 [details]
Here is the patch

There have 3 files reference to Windows.h:

ld/config.in: AC_CHECK_HEADERS([Windows.h],[enable_plugins=yes],[],[AC_INCLUDES_DEFAULT])
ld/configure: ...

ld/plugin.c: #include <Windows.h>

But in the mingw or mingw-w64 repository, the name should be windows.h:

http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/w32api/include/?cvsroot=src

https://mingw-w64.svn.sourceforge.net/svnroot/mingw-w64/trunk/mingw-w64-headers/include/

So in an case sensitive filesystem/platform, AC_CHECK_HEADERS will fail, and the plugin will not build.
Comment 1 Dongsheng Song 2011-04-06 07:55:31 UTC 
commit b6d40962544d522ac71d42dca804ea686a650f4d
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Mon Mar 28 10:27:07 2011 +0000

        * configure.in: Check for windows.h, not Windows.h.
        * configure: Regenerate.
        * plugin.c: Include windows.h, not Windows.h.