Bug 12223 - GDB becomes unusable if it fails to speculate about frame information on ARM.
Summary: GDB becomes unusable if it fails to speculate about frame information on ARM.
Status: NEW
Alias: None
Product: gdb
Classification: Unclassified
Component: tdep (show other bugs)
Version: HEAD
: P2 critical
Target Milestone: ---
Assignee: Jacob Bramley
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-17 10:08 UTC by Jacob Bramley
Modified: 2012-03-06 18:01 UTC (History)
1 user (show)

See Also:
Host: ARM
Target: ARM
Build:
Last reconfirmed:


Attachments
patch to handle memory access errors (423 bytes, patch)
2012-02-28 17:51 UTC, martin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Bramley 2010-11-17 10:08:56 UTC
Where frame debug information is not available, such as when executing
some JIT-compiled code in Mozilla's Trace Monkey, GDB tries to guess
what the frame looks like by assuming that the 'FP' register points to a
traditional frame. Most JIT-compilers don't actually use a traditional
frame, so this generally fails, and no frame information can be found.

Provided that the FP points to a valid memory address and it looks
enough like a frame that GDB can attempt to read it, everything works
fine. No, you don't get backtraces, but you can still do
instruction-level debugging. By some amazing coincidence, at least Trace
Monkey has had this property until recently.

Trace Monkey now stores a value at *fp which is not a valid pointer, and
GDB falls over. When JIT-compiled code is stepped into, GDB dumps the
following to the terminal:

(gdb) si
Cannot access memory at address 0x5ffff8

(The memory address depends on the value at *fp.)

Any further commands (including 'quit') result in a repeat of the
message, and the debug session is essentially lost.

----

The fix for this requires a modification of the logic in
arm_scan_prologue as follows:
  • Detect memory access errors in frame speculation and bail out
    cleanly.
  • Use memory access functions which don't print to the terminal if an
    error is detected. (Otherwise, even if the speculation fails
    cleanly, the user still sees an error message after every command in
    the JIT-compiled code.)

Instruction-level debug is once again possible with these changes.

----

Refer here for my original description of the problem:
https://bugzilla.mozilla.org/show_bug.cgi?id=605758#c6
Comment 1 Pedro Alves 2010-11-17 10:32:47 UTC
This does not invalidate your report in any way, but I'd just like to point out
GDB's JIT compiler interface which Trace Monkey could use to provide GDB with debug info for the JIT compiled code.  See:

 <http://sourceware.org/gdb/download/onlinedocs/gdb.html#JIT-Interface> 

You may well be aware of it, but, there it goes for the archives.
Comment 2 Jacob Bramley 2010-11-17 11:10:35 UTC
(In reply to comment #1)
>  <http://sourceware.org/gdb/download/onlinedocs/gdb.html#JIT-Interface> 

Oh I agree, it would be nice if we could use the JIT interface. If nothing else, it would presumably give us back-trace information through JIT frames, and that could be useful at times.

However, integrating it into Trace Monkey is a rather more fiddly task than fixing GDB, and it doesn't scale when we start looking at more than a handful of JIT compilers, so I'd like to fix the problem in GDB first.
Comment 3 martin 2012-02-28 17:51:54 UTC
Created attachment 6255 [details]
patch to handle memory access errors

I've been having the same problem here in a situation where r11 isn't the frame pointer and the attached patch has been working well for me.
Comment 4 Pedro Alves 2012-03-06 18:01:57 UTC
read_memory is just a wrapper for target_read_memory that throws MEMORY_ERROR on access errors.  So instead of further wrapping read_memory in try/catch, the right thing to do is to use target_read_memory (+extract_(un)signed_integer) directly, thus avoiding the exception to begin with.

Please do read through CONTRIBUTE linked from <http://sourceware.org/gdb/contribute/>.

Thanks!