Bug 12177 - bfd/elf32-bfin.c: overwritten assignment
Summary: bfd/elf32-bfin.c: overwritten assignment
Status: RESOLVED FIXED
Alias: None
Product: binutils
Classification: Unclassified
Component: binutils (show other bugs)
Version: 2.21
: P2 normal
Target Milestone: ---
Assignee: Mike Frysinger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-01 14:56 UTC by Nicolas Kaiser
Modified: 2010-11-14 22:04 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Kaiser 2010-11-01 14:56:26 UTC 
Hi there!

I noticed an assignment that gets overwritten instantly, and in
its context it looks to me like the arguments might have been
transposed.

Best regards,
Nicolas Kaiser
---
--- a/bfd/elf32-bfin.c	2010-06-27 06:07:51.000000000 +0200
+++ b/bfd/elf32-bfin.c	2010-11-01 15:36:06.253701659 +0100
@@ -3463,7 +3463,7 @@ _bfin_create_got_section (bfd *abfd, str
       flags = BSF_GLOBAL | BSF_WEAK;
     }
 
-  flags = pltflags;
+  pltflags = flags;
   pltflags |= SEC_CODE;
   if (bed->plt_not_loaded)
     pltflags &= ~ (SEC_CODE | SEC_LOAD | SEC_HAS_CONTENTS);
Comment 1 Mike Frysinger 2010-11-14 20:12:59 UTC 
looks like a bug we imported from FRV when Bernd merged changes from it
Comment 2 Mike Frysinger 2010-11-14 22:04:55 UTC 
i lied, it isnt a bug.  current code is correct, just unused in the Blackfin side (since we dont create a "_gp" symbol).  ive punted the unused stuff.