Bug 12022 - Allow foreach to order iterations for aggregates on @min @max and @avg operators
Summary: Allow foreach to order iterations for aggregates on @min @max and @avg operators
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: translator (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-14 20:33 UTC by William Cohen
Modified: 2012-10-13 16:34 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description William Cohen 2010-09-14 20:33:58 UTC 
The foreach currently only sorts based on the @count for aggregates. It would be
very nice to allow ordering based on the the other aggregate operators.
latencytap make use of a sort based on the @max times to show what things have
the largest latencies.
Comment 1 Josh Stone 2010-09-14 20:58:25 UTC 
Frank and I discussed this a long time ago, but I guess we then forgot.  Here it
is in the mailing list archives (multiple links because the threading broke).

sort a foreach on a stat value?
jistone: http://sourceware.org/ml/systemtap/2005-q4/msg00550.html
   fche: http://sourceware.org/ml/systemtap/2006-q1/msg00113.html
jistone: http://sourceware.org/ml/systemtap/2006-q1/msg00142.html
   fche: http://sourceware.org/ml/systemtap/2006-q1/msg00175.html
jistone: http://sourceware.org/ml/systemtap/2006-q1/msg00219.html
Comment 2 William Cohen 2010-09-15 14:21:47 UTC 
Certainly things could be implemented with another foreach to sort things and
can do that with latencytap. This was something to simplify the user scripts and
avoid some of overhead of having two foreach loops.
Comment 3 Frank Ch. Eigler 2012-10-13 16:34:39 UTC 
commit fd5689dc et al.