Bug 11457 - unresolved *mib_filter_key functions
Summary: unresolved *mib_filter_key functions
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: tapsets (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-30 22:45 UTC by Josh Stone
Modified: 2010-07-12 15:02 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Stone 2010-03-30 22:45:58 UTC 
There are three filter functions that are expected to be provided by the user:
  linuxmib_filter_key(sk,op)
  ipmib_filter_key(skb,op,SourceIsLocal)
  tcpmib_filter_key(sk,op)


$ ./run-stap -L '**?' >/dev/null
semantic error: unresolved arity-2 function: identifier 'linuxmib_filter_key' at
/home/jistone/systemtap/build/../tapset/linuxmib.stp:33:8
        source: 	key = linuxmib_filter_key(sk,op);
                	      ^
semantic error: unresolved arity-3 function: identifier 'ipmib_filter_key' at
/home/jistone/systemtap/build/../tapset/ipmib.stp:326:8
        source: 	key = ipmib_filter_key(skb,op,SourceIsLocal);
                	      ^
...


We should at least provide *some* default implementations, even if users will
usually want to customize them.  This could be done the same way
__indent_timestamp() is provided in indent-default.stp.


(I would eventually like "stap -L '**?'" to be a regular test...)
Comment 1 Wenji Huang 2010-04-21 06:18:37 UTC 
(In reply to comment #0)
> 
> We should at least provide *some* default implementations, even if users will
> usually want to customize them.  This could be done the same way
> __indent_timestamp() is provided in indent-default.stp.
> 

Yes, to make building test pass, there are some implementations of such
*mib_filter_key functions.  How about to move them to tapset?

> 
> (I would eventually like "stap -L '**?'" to be a regular test...)

Agreed.
Comment 2 Wenji Huang 2010-04-21 06:20:03 UTC 
(In reply to comment #1)
> (In reply to comment #0)
> > 
> > We should at least provide *some* default implementations, even if users will
> > usually want to customize them.  This could be done the same way
> > __indent_timestamp() is provided in indent-default.stp.
> > 
> 
> Yes, to make building test pass, there are some implementations of such
> *mib_filter_key functions.  How about to move them to tapset?

More clear, see testsuite/buildok/*mib-all-probes.stp
Comment 3 William Cohen 2010-07-12 15:02:00 UTC 
The following commits should address this:

78af6aa67f596e7f13b7c3ce5ab134a631fbdc8b
549d93ad41187c4d4c2b302fbea0b6adbecd4526