Bug 11338 - use @defined in tapsets
Summary: use @defined in tapsets
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: tapsets (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: David Smith
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 16:27 UTC by David Smith
Modified: 2010-09-21 20:02 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Smith 2010-03-02 16:27:16 UTC
Now that the @defined() predicate for compile-time $var error catching has been
implemented (bug #11005), the tapsets need to actually use this new feature. 
This will change code segments like:

%( kernel_vr >= "2.6.24" %?
	prot = $prot
%:
	prot = $__prot
%)

to: 
	prot = (@defined($prot) ? $prot : $__prot)
Comment 1 David Smith 2010-03-05 17:15:48 UTC
Commit ae34ff1 fixed this for the syscall tapsets.
Comment 2 David Smith 2010-03-08 19:39:52 UTC
Commit 08f88cd fix this problem for the tty, scheduler, and vfs tapsets.
Comment 3 David Smith 2010-03-09 21:40:32 UTC
Commit 595187e fixed this for the task, dentry, and scsi tapsets.
Comment 4 David Smith 2010-03-26 18:27:34 UTC
Commit 961479c improves this problem for the tcpmib tapset.
Comment 5 David Smith 2010-03-26 19:18:52 UTC
Commit 7ad7610] fixes inet_sock tapset.
Comment 6 David Smith 2010-04-26 16:57:11 UTC
Commit 8989596 fixes nfsd tapset.
Comment 7 David Smith 2010-04-27 16:20:00 UTC
Commit c893ecc fixes the nfs tapset.
Comment 8 David Smith 2010-05-03 18:20:29 UTC
Commit 45f2255 fixes the memory tapset.
Comment 9 David Smith 2010-05-04 17:07:44 UTC
Commit f5104f6 fixes the signal tapset.
Comment 10 David Smith 2010-05-05 17:34:35 UTC
Commit 2adaeba removed a kernel version check from tcp.stp.
Comment 11 David Smith 2010-07-01 16:45:40 UTC
Commit b866a56 fixed this for linuxmib.stp.
Comment 12 David Smith 2010-09-21 20:02:05 UTC
Since I've made a pass through all the tapsets, removing kernel version checks
when possible, let's close this one.