Bug 11201 - Distributed scripts should not be removed on clean
Summary: Distributed scripts should not be removed on clean
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: translator (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-21 09:06 UTC by Eugeniy Meshcheryakov
Modified: 2011-03-16 21:19 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Patch (238 bytes, patch)
2010-01-21 09:08 UTC, Eugeniy Meshcheryakov 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugeniy Meshcheryakov 2010-01-21 09:06:18 UTC 
Currently for some unknown to me reason toplevel Makefile removes some scripts
(pkglibexec_SCRIPTS) in "clean" target. This should not be done because they
cannot be restored (as far as I can see, otherwise they should not be
distributed at all).
Comment 1 Eugeniy Meshcheryakov 2010-01-21 09:08:26 UTC 
Created attachment 4546 [details]
Patch

I don't commit this patch myself because I'm not sure why that variable was
set. Also I have no idea why is pkglibexec_PROGRAMS is there.
Comment 2 Mark Wielaard 2010-01-21 09:39:08 UTC 
It was introduced a long time ago to support building elfutils inside systemtap.
Maybe Roland can help figure out if the current usage still matches to original
intent.

commit e460639fa72fda6ff89bb77ab48516f6f478c909
Author: roland <roland>
Date:   Mon Dec 12 05:52:00 2005 +0000

    2005-12-11  Roland McGrath  <roland@redhat.com>
    
        PR 1916
        * configure.ac: Grok --with-elfutils.
        * Makefile.am [BUILD_ELFUTILS] (install-elfutils, stamp-elfutils):
        New targets.
        [BUILD_ELFUTILS] (stap_LDFLAGS, stap_LDFLAGS): Add flags
        to point at local elfutils build.
        [BUILD_ELFUTILS] (BUILT_SOURCES): Add stamp-elfutils.
        [BUILD_ELFUTILS] (stap_DEPENDENCIES): New variable.
        [BUILD_ELFUTILS] (lib-elfutils/libdw.so): New target.
        [BUILD_ELFUTILS] (install-exec-local): Depend on install-elfutils.
        (loc2c_test_LDADD): Set this to $(stap_LDADD).
        (loc2c_test_CPPFLAGS, loc2c_test_LDFLAGS): New variables.
        * Makefile.in: Regenerated.
        * compile: New file from automakeland.
        * systemtap.spec.in (elfutils_version): Require 0.118 or later.
        [bundled_elfutils]: Remove old hacks for building elfutils, and rely
        on configure --with-elfutils instead.
        * Makefile.am (pkglibexecdir): New variable.
        (AM_CPPFLAGS): Use it.
        (pkglibexec_PROGRAMS): Set this instead of noinst_PROGRAMS with stpd.
        (pkglibexec_SCRIPTS, CLEANFILES): New variables.
        (install-exec-local): Target removed.
        * runtest.sh: Set LD_LIBRARY_PATH when lib-elfutils is in use.
Comment 3 Dave Brolley 2010-01-21 16:52:37 UTC 
(In reply to comment #1)
> Created an attachment (id=4546)
> Patch
> 
> I don't commit this patch myself because I'm not sure why that variable was
> set.

Thanks. I've committed your patch.

> Also I have no idea why is pkglibexec_PROGRAMS is there.

In addition to what Mark said, it is now being used for stap-sign-module,
stap-client-connect and stap-server-connect which are present at the root of the
build tree and are now installed in libexec/systemtap as per bugs 10247 and 10276.
Comment 4 Frank Ch. Eigler 2010-02-26 14:29:56 UTC 
committed