Bug 10656 - readelf: move a variable to a header file
Summary: readelf: move a variable to a header file
Status: RESOLVED FIXED
Alias: None
Product: binutils
Classification: Unclassified
Component: binutils (show other bugs)
Version: 2.21
: P2 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-18 09:55 UTC by Dmitry Gorbachev
Modified: 2009-09-25 18:17 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
Project(s) to access:
ssh public key:


Attachments
Patch (trivial) (237 bytes, patch)
2009-09-18 09:55 UTC, Dmitry Gorbachev
Details | Diff
Patch for gprof (326 bytes, patch)
2009-09-19 13:25 UTC, Dmitry Gorbachev
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Gorbachev 2009-09-18 09:55:14 UTC
 
Comment 1 Dmitry Gorbachev 2009-09-18 09:55:53 UTC
Created attachment 4204 [details]
Patch (trivial)
Comment 2 Dmitry Gorbachev 2009-09-19 13:25:43 UTC
Created attachment 4218 [details]
Patch for gprof
Comment 3 Sourceware Commits 2009-09-25 09:58:04 UTC
Subject: Bug 10656

CVSROOT:	/cvs/src
Module name:	src
Changes by:	nickc@sourceware.org	2009-09-25 09:57:50

Modified files:
	gprof          : ChangeLog hist.c hist.h 
	binutils       : ChangeLog dwarf.h readelf.c 

Log message:
	PR 10656
	* readelf.c: Remove duplicate declaration of variable do_wide.
	* dwarf.h: Add export of do_wide.
	
	* hist.h: Move declaration of histograms and num_histograms
	variables from here to...
	* hist.c: ...here.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gprof/ChangeLog.diff?cvsroot=src&r1=1.266&r2=1.267
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gprof/hist.c.diff?cvsroot=src&r1=1.22&r2=1.23
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gprof/hist.h.diff?cvsroot=src&r1=1.10&r2=1.11
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/binutils/ChangeLog.diff?cvsroot=src&r1=1.1539&r2=1.1540
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/binutils/dwarf.h.diff?cvsroot=src&r1=1.11&r2=1.12
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/binutils/readelf.c.diff?cvsroot=src&r1=1.462&r2=1.463

Comment 4 Nick Clifton 2009-09-25 09:59:07 UTC
Hi Dmitry,

  Thanks for reporting these problems and for providing patches to fix them.  I
have applied your patches along with the following changelog entries.

Cheers
  Nick

binutils/ChangeLog
2009-09-25  Dimitry Gorbachev  <d.g.gorbachev@gmail.com>

	PR 10656
	* readelf.c: Remove duplicate declaration of variable do_wide.
	* dwarf.h: Add export of do_wide.

gprof/ChangeLog
2009-09-25  Dimitry Gorbachev  <d.g.gorbachev@gmail.com>

	PR 10656
	* hist.h: Move declaration of histograms and num_histograms
	variables from here to...
	* hist.c: ...here.
Comment 5 Dmitry Gorbachev 2009-09-25 18:17:18 UTC
Thanks!