Bug 10395 - testsuite/systemtap.base/kmodule.exp fails when ext3 isn't a module
Summary: testsuite/systemtap.base/kmodule.exp fails when ext3 isn't a module
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: testsuite (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-15 10:29 UTC by Mark Wielaard
Modified: 2013-06-25 17:40 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wielaard 2009-07-15 10:29:34 UTC
testsuite/systemtap.base/kmodule.exp depends on ext3 being loaded as a kernel
module, but on both my fedora rawhide and rhel 5.4-beta installs ext3 isn't.
Comment 1 David Smith 2013-06-25 16:02:53 UTC
Besides the fact that kmodule.exp depends on ext3 being loaded as a module, the test is supposed to fail when the hit count is 0, but it doesn't fail (since the test regular expression is too broad).

=====
Running ./systemtap.base/kmodule.exp ...
executing: stap -v ./systemtap.base/kmodule.stp
spawn stap -v ./systemtap.base/kmodule.stp
Pass 1: parsed user script and 103 library script(s) using 114480virt/35572res/2852shr/33176data kb, in 240usr/80sys/326real ms.
Pass 2: analyzed script: 3 probe(s), 0 function(s), 0 embed(s), 1 global(s) using 276760virt/38176res/3324shr/35352data kb, in 100usr/5730sys/5910real ms.
Pass 3: translated to C into "/tmp/stapubZ1Py/stap_e86d967c395b75c88cfcf042264c529c_1280_src.c" using 276760virt/38484res/3632shr/35352data kb, in 0usr/10sys/43real ms.
Pass 4: compiled C into "stap_e86d967c395b75c88cfcf042264c529c_1280.ko" in 2570usr/2490sys/4930real ms.
Pass 5: starting run.
systemtap starting probe
PASS: ./systemtap.base/kmodule.stp startup
spawn -ignore SIGHUP sync
PASS: ./systemtap.base/kmodule.stp load generation
systemtap ending probe
count = 0
PASS: ./systemtap.base/kmodule.stp shutdown and output
Pass 5: run completed in 20usr/360sys/1400real ms.
metric:	./systemtap.base/kmodule.stp 	240	80	326	100	5730	5910	0	10	43	2570	2490	4930	20	360	1400
testcase ./systemtap.base/kmodule.exp completed in 12 seconds
=====

Since 'count = 0', the test should have failed.
Comment 2 David Smith 2013-06-25 17:40:01 UTC
Fixed in commit 03551ba by making kmodule.exp build and install its own test kernel module.