Can't give a town its independence

[Stan Shebs]

Jim Kingdon wrote:
> 
> Without the enclosed fix (running xconq from CVS), "G" enter (to give
> a town its independence) causes a core dump.  It would also be
> possible to fix this in prep_change_side_action or elsewhere; I didn't
> see much in the way of comments regarding how indepside should be
> treated (see for example case 'S' in execute_action which turns NULL
> into indepside).  Establishing a consistent convention would probably
> avoid a variety of bugs of this sort.

Hans should answer this, but he's probably hiding. :-)  But seriously,
we made a change several months ago to set unit->side of independent
units to be indepside rather than NULL, so as to allow independent units
to do a minimal amount of acting on their own.  However, a convention
that has been in use for many years has a way of worming its way into
every part of the code, and we're still turning up bogosities here and
there.  The existing doc is probably schizophrenic too, some reflecting
the old situation and some the new.

So anyway, changing side_number probably masks the real problem, and
we should look at the callers more closely.

Stan