[Bug runtime/32194] New: Reflect the uprobe_unregister() split

mcermak at redhat dot com sourceware-bugzilla@sourceware.org
Fri Sep 20 15:02:05 GMT 2024


https://sourceware.org/bugzilla/show_bug.cgi?id=32194

            Bug ID: 32194
           Summary: Reflect the uprobe_unregister() split
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: mcermak at redhat dot com
  Target Milestone: ---

Kernel-6.12 comes with:

commit 04b01625da130c7521b768996cd5e48052198b97
Author: Peter Zijlstra <peterz@infradead.org>
Date:   Tue Sep 3 10:46:00 2024 -0700

    perf/uprobe: split uprobe_unregister()

    With uprobe_unregister() having grown a synchronize_srcu(), it becomes
    fairly slow to call. Esp. since both users of this API call it in a
    loop.

    Peel off the sync_srcu() and do it once, after the loop.

    We also need to add uprobe_unregister_sync() into uprobe_register()'s
    error handling path, as we need to be careful about returning to the
    caller before we have a guarantee that partially attached consumer won't
    be called anymore. This is an unlikely slow path and this should be
    totally fine to be slow in the case of a failed attach.


Systemtap needs to reflect this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Systemtap mailing list