[Bug releng/31703] New: Git detection false positive when 'which' not available

[thaines.astro at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31703

            Bug ID: 31703
           Summary: Git detection false positive when 'which' not
                    available
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: releng
          Assignee: systemtap at sourceware dot org
          Reporter: thaines.astro at gmail dot com
  Target Milestone: ---

The fedora containers don't have 'which' installed by default:

  $ docker run --rm fedora:39 which
  docker: Error response from daemon:
    failed to create task for container:
    failed to create shim task:
    OCI runtime create failed:
    runc create failed:
    unable to start container process: exec: "which":
    executable file not found in $PATH: unknown.

The check in git_version.sh notices the failure, but doesn't exit early.

git_found=yes
if [ "x$GIT" = "xgit" ] && [ x`which $GIT 2>/dev/null` = "x" ]; then
    git_found="'$GIT' not found"
    break
fi

I _think_ the solution here is to 'exit' instead of 'break'. Thoughts?

Thanks.
- Tim

-- 
You are receiving this mail because:
You are the assignee for the bug.