[Bug runtime/30405] Kernel errors with Fedora 36's 6.2.12 debug kernels

agentzh at gmail dot com sourceware-bugzilla@sourceware.org
Sun Apr 30 05:51:49 GMT 2023


https://sourceware.org/bugzilla/show_bug.cgi?id=30405

--- Comment #1 from agentzh <agentzh at gmail dot com> ---
The following patch seems to fix the error itself:

```
diff --git a/runtime/linux/kprobes.c b/runtime/linux/kprobes.c
index c0f4f5c0f..72f4b148e 100644
--- a/runtime/linux/kprobes.c
+++ b/runtime/linux/kprobes.c
@@ -819,9 +819,7 @@ stapkp_init(struct stap_kprobe_probe *probes,
 #ifdef STAPCONF_MODULE_MUTEX
        mutex_lock(&module_mutex);
 #endif
-       preempt_disable();
        kallsyms_on_each_symbol(stapkp_symbol_callback, &sd);
-       preempt_enable();
 #ifdef STAPCONF_MODULE_MUTEX
        mutex_unlock(&module_mutex);
 #endif
```

But it seems to effectively revert the previous commit for fixing a softlockup
in PR20735:

```
commit 58c9bd1563aece0c020d9c8da5cf8db8ef028439
Author: David Smith <dsmith@redhat.com>
Date:   Thu Nov 10 09:59:16 2016 -0600

    Fix PR20735 by updating kprobes.c to avoid a soft lockup.

    * runtime/linux/kprobes.c: Instead of grabbing the module mutex around
      calling kallsyms_on_each_symbol(), just disable/enable preemption
      instead to avoid a soft lockup.
```

What should we do then?

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Systemtap mailing list