[Bug translator/23512] New: regression in --privilege=stapusr operation

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23512

            Bug ID: 23512
           Summary: regression in --privilege=stapusr operation
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: fche at redhat dot com
  Target Milestone: ---

My commits for PR23160,PR14690 have caused a regression in the way
privilege-testing of elaboration of embedded-c tapset functions is handled. 
New code changes the timing at which the /* unprivileged */ type pragmas are
processed.  Now they can fail for functions like kernel_string() even though
they are not called, even transitively, from the end-user script.  This breaks
e.g. the unprivileged-myproc test cases.

It turns out we run symbol elaboration in an overly inclusive manner.  Any
function defined in a tapset file chosen for inclusion is fully processed, even
though it may not be transitively called at all.  This represents perhaps
considerable wasted translation effort, esp. considering expensive constructs
like @cast().  We should not spend any serious efforts processing parts of
tapsets that are not reachable from the end-user script.  This suggests the
resolve_syms pass must be iterative/relaxation-based, like the optimization
passes later on.

-- 
You are receiving this mail because:
You are the assignee for the bug.