[Bug uprobes/21238] New: Failed user probing does not return proper error

[v.mayatskih at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21238

            Bug ID: 21238
           Summary: Failed user probing does not return proper error
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: uprobes
          Assignee: systemtap at sourceware dot org
          Reporter: v.mayatskih at gmail dot com
  Target Milestone: ---

Systemtap 3.1. When uprobe_register fails, systemtap does not print error code:

WARNING: probe process("/usr/lib64/libstdc++.so.6.0.19").function("_Znam")
inode-offset 000000000005f1c0 registration error (rc 0)
WARNING: probe process("/usr/lib64/libstdc++.so.6.0.19").function("_Znwm")
inode-offset 000000000005f0b0 registration error (rc 0)

This fixes it:

--- a/runtime/linux/uprobes-inode.c     2017-02-17 12:37:01.000000000 -0500
+++ b/runtime/linux/uprobes-inode.c     2017-03-09 14:13:28.271403434 -0500
@@ -390,7 +390,8 @@
                                         c->return_p ? "ret" : "",
c->probe->index);
                                continue;
                        }
-                       if (stapiu_register(target->inode, c) != 0)
+                       ret = stapiu_register(target->inode, c);
+                       if (ret != 0)
                                _stp_warn("probe %s inode-offset %p
registration error (rc %d)",
                                          c->probe->pp, (void*) (uintptr_t)
c->offset, ret);
                }


WARNING: probe process("/usr/lib64/libstdc++.so.6.0.19").function("_Znam")
inode-offset 000000000005f1c0 registration error (rc -5)
WARNING: probe process("/usr/lib64/libstdc++.so.6.0.19").function("_Znwm")
inode-offset 000000000005f0b0 registration error (rc -5)
WARNING: task_finder mmap inode-uprobes callback for task 11766 failed: -5

Looks like a regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.