[PATCH 00/12] MIPS port

[Marcin Nowakowski]

Hi Frank,

On 11.10.2016 17:00, Frank Ch. Eigler wrote:
> Marcin Nowakowski <marcin.nowakowski@imgtec.com> writes:
>
>> This patch series attempts to bring MIPS support to systemtap. It is
>> largely based on an earlier work by Victor Kamensky and Crestez Dan
>> Leonard who have previously attempted to add MIPS support, but which
>> has never been completed.  [...]
>
> Thank you.

Thank you for a quick action to accept the patches - I didn't expect the 
process to go so smooth :)

>
>> There is no good guide on how to add a new architecture to SystemTap,
>> so there might be things that I have missed or which are not done
>> entirely correctly - I hope that with some guidance from the
>> maintainers I can get it all merged into the tree. [...]
>
> After a quick look over the patches and an x86-64 smoke-test to detect
> "friendly fire", the whole set is now merged.
>
> As to how to port to new architectures, indeed we lack formal
> documentation on this.  (It happens so rarely!)  One minimal thing we
> could do would be to add comment markers like /* PORTING */ to all the
> places you just had to touch.  (It would be similar to the "PRERELEASE"
> comment to mark pre-release checklist locations.)  Would that have
> helped you?

Yes, I think a clear label showing things that require porting can help. 
Obviously it wouldn't be able to show everything, as there might be some 
arch-dependent features that are only specific to a given arch and 
wouldn't be known otherwise, but for most contexts that would be helpful 
anyway.

Marcin