[PATCH 1/3] add test cases for arith

"Zhou, Wenjian/周文剑" zhouwj-fnst@cn.fujitsu.com
Wed Dec 9 09:43:00 GMT 2015


On 12/08/2015 11:09 PM, Frank Ch. Eigler wrote:
>
> Hi -
>
>
> Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> writes:
>
>> 	* testsuite/systemtap.base/arith.stp: add more cases
>> [...]
>
> I see nothing wrong with the proposed tests, but they seem to add very
> little new coverage to the sorts of things thoroughly exercised
> elsewhere.  This set of arith.stp operator tests are probably OK, just
> because we have their siblings there, but whitespace.stp IMHO doesn't
> do anything special.
>

Hi Frank,

The whitespace.stp tests that if the systemtap works well with white space
and null statement(";").
If you think it is not needed, I won't insist.

-- 
Thanks
Zhou

> (By the way, there are also all kinds of other contributions worth
> considering, be it documentation or bug or features fixes.  We'd love
> to mentor folks with any of these areas.)
>
> - FChE
>
>




More information about the Systemtap mailing list