[PATCH] add testcases for variables scope

[David Smith]

On 11/05/2015 07:09 PM, "Zhou, Wenjian/周文剑" wrote:
> On 11/06/2015 12:55 AM, David Smith wrote:

>> ... stuff deleted ...
>>
>>> I think there are two ways to fix it, if it needs to be fixed.
>>> 1,
>>> adjust the function stap_run
>>>
>>> 2,
>>> change the way of printing "systemtap test success" (likes the
>>> implementation in this patch)
>>>
>>> I prefer the second, for it won't introduce some other errors.
>>
>> You way #2 above would have worked fine. I fixed it with a 3rd solution,
>> just changing the expected result string to be 2 copies of the
>> 'all_pass_string':
>>
>> <https://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commit;h=0d7d53dd805f636278858651a649d57fb87ba6c8>
>>
>>
>> Thanks for finding this.
> 
> The testcase "if" is just an example.
> There are still many other testcases having this problem...
> Should I fix it?

Yes, it would be great if this was fixed. The first step would be to get
a list of all the testcases with the problem. Then we'd fix it using
either method #2 or #3.

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)