[PATCH 1/1] stp: rt: replace spin_lock with stp style lock and use STP_ALLOC_FLAGS

Frank Ch. Eigler fche@redhat.com
Tue Oct 27 13:52:00 GMT 2015


dsmith wrote:

> [...]
> Here's the big question - on the realtime kernel, is it ever safe to sleep?

> If the answer to the previous question is "no", then your change
> [switching to STP_ALLOC_FLAGS] is correct. [...]

But even then, not in general.  If we use atomic memory allocation flags only,
we may suffer unnecessary alloc failures on normal kernels.  If we do this
switch, perhaps it needs to be done rt-conditionally.  It might be as simple
as to "#define STP_ALLOC_SLEEP_FLAGS  ..." differently on rt (CONFIG_*...).

- FChE



More information about the Systemtap mailing list