[PATCH 1/1] stp: rt: replace spin_lock with stp style lock and use STP_ALLOC_FLAGS

yzhu1 Yanjun.Zhu@windriver.com
Mon Oct 26 03:19:00 GMT 2015


Hi, David

I do not have this backtrace. Because STP_ALLOC_SLEEP_FLAGS will cause 
kmalloc sleep,
so I replaced it with STP_ALLOC_FLAGS.

Zhu Yanjun

On 10/23/2015 12:34 AM, David Smith wrote:
> On 10/22/2015 02:46 AM, Zhu Yanjun wrote:
>> -rt mode spin lock lead to __might_sleep calltrace.
>> Replacing spin lock with stp type raw lock and
>> changing STP_ALLOC_SLEEP_FLAGS to STP_ALLOC_FLAGS solves the problem.
> In general, this patch looks fine. However, I'm not too sure about the
> STP_ALLOC_SLEEP_FLAGS bit. Can show us a backtrace that happens with
> your spinlock changes but without the alloc flags changes or explain why
> the alloc flags change is necessary? It could be that we're using the
> wrong set of flags in the caller.
>
> Thanks.
>



More information about the Systemtap mailing list