[Bug tapsets/18649] int_arg() misbehaves on x86[_64] for 32-bit uprobe in binary having debuginfo

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18649

--- Comment #10 from David Smith <dsmith at redhat dot com> ---
(In reply to Martin Cermak from comment #9)
> Created attachment 8459 [details]
> proposed patch
> 
> Attached patch seems to work for me. It doesn't contain test coverage and
> documentation yet. Does it look good so far?

I see one code omission - the changes to session.cxx don't look complete. You
updated the regular constructor, but not the copy constructor for the
systemtap_session class.

In general it seems odd to have both session->prologue_searching and
session->prologue_searching_mode. I'd think you'd get rid of
session->prologue_searching and make "-P" a synonym for
"--prologue-searching=always". Also, you'll have to be careful with
ENABLE_PROLOGUES.

-- 
You are receiving this mail because:
You are the assignee for the bug.