[PATCH v3 1/2] systemtap/tapsets.cxx: Adjusted for multiple static functions

[Hemant Kumar]

On 04/08/2015 09:41 PM, Josh Stone wrote:
> On 04/08/2015 06:43 AM, Mark Wielaard wrote:
>> The patch does look OK to me. But my C++ container knowledge is a little
>> shaky. So some questions. First there is still a comment in the code
>> saying:
>>
>>>     // TODO: Use a multimap in case there are multiple static
>>>     // functions with the same name?
>>>     map_by_addr.insert(make_pair(addr, fi));
>> But map_by_addr is already a multimap as introduced in commit 1c6b77
>> PR10327: resolve symbol aliases to dwarf functions by Josh. Which seems
>> to solve a somewhat similar issue in the case we do have DWARF
>> information. Josh, do you remember why that comment was kept?
> Since it's talking about "same name", I believe that comment is actually
> referring to the line *before* it, which sets map_by_name.
>

Right, will remove the above TODO in the next version.

-- 
Thanks,
Hemant Kumar