[PATCH] filename in tapset nfs.proc.open and nfs.proc.release

[Lukas Berk]

Hey,

----- Original Message -----
> On 12/15/2014 02:34 PM, Frank Ch. Eigler wrote:
> > David Smith <dsmith@redhat.com> writes:
[...]
> > One way to have it both ways is to extend each these probe aliases
> > (only some dozen or so) to define a new context variable like
> > 'fullpath' sibling of 'file*name'.  It would fully resolve the path
> > name.  (I'd certainly switch argstr over to print that instead of the
> > last component.)
> 
> I'm OK with providing a 'fullpath' variable (which would get optimized
> out if you didn't use it), but I'd need more convincing about the wisdom
> of switching argstr over to using it. As you said above "some might not
> want to pay that".

It may be the case where, those looking to use the argstr convenience variable
simply want to print out all the information being passed, regardless of
the cost, already.  In that case, finding they need to craft another, very
similar script to get a piece of related information (without knowing why it
wasn't passed in the first place) could be frustrating.  I've always looked
at argstr (rightly or wrongly) as 'just tell me everything being passed',
knowing I could write a more tailored script later if needed.

Either way, I'd recommend noting the choice we've made, and the alternate
variable in a manpage.

Cheers,

Lukas