[PATCH] filename in tapset nfs.proc.open and nfs.proc.release

Frank Ch. Eigler fche@redhat.com
Mon Dec 15 20:34:00 GMT 2014


David Smith <dsmith@redhat.com> writes:

> [...]  Thanks for the patch, but I don't think this is really what
> we want here. Here's why: [...]

The full pathname is almost certainly more useful in the many probes
where __file_filename() is currently used (I recall receiving some
complaints about that long ago, just not getting to the bottom), and
the cost is not -that- high.  But point taken, some might not want to
pay that.

One way to have it both ways is to extend each these probe aliases
(only some dozen or so) to define a new context variable like
'fullpath' sibling of 'file*name'.  It would fully resolve the path
name.  (I'd certainly switch argstr over to print that instead of the
last component.)

- FChE



More information about the Systemtap mailing list