[PATCH] Remove <stdint.h> from <sys/sdt.h>

Chung-Lin Tang cltang@codesourcery.com
Tue Oct 21 09:09:00 GMT 2014


Hi,
We're in the process of considering adding the <sys/sdt.h> header during
the build of a full toolchain, which will allow the enabling of
SystemTap probes in some target libraries (e.g. glibc).

There's a small problem that I'm encountering:  we're configuring glibc
with --enable-systemtap, but the configure tests tries a test compile
with <sys/sdt.h> before we even have glibc (headers) installed, a small
circular dependency actually.

I'm guessing the [u]int(8/16/32)_t types were probably historically used
in the <sys/sdt.h> header, but as of currently I see no need of
<stdint.h> in there. May I suggest to simply remove the #include?  (I've
attached the one-liner patch to be clear)

Thanks,
Chung-Lin
-------------- next part --------------
diff --git a/includes/sys/sdt.h b/includes/sys/sdt.h
index ba04c12..c2de2a9 100644
--- a/includes/sys/sdt.h
+++ b/includes/sys/sdt.h
@@ -30,7 +30,6 @@
 # define _SDT_DEPAREN_11(a,b,c,d,e,f,g,h,i,j,k)		a b c d e f g h i j k
 # define _SDT_DEPAREN_12(a,b,c,d,e,f,g,h,i,j,k,l)	a b c d e f g h i j k l
 #else
-# include <stdint.h>
 # define _SDT_PROBE(provider, name, n, arglist) \
   do {									    \
     __asm__ __volatile__ (_SDT_ASM_BODY(provider, name, _SDT_ASM_ARGS, (n)) \


More information about the Systemtap mailing list