[PATCH] fixes for ENABLE_NLS=0
Josh Stone
jistone@redhat.com
Fri Mar 22 17:19:00 GMT 2013
On 03/22/2013 01:45 AM, groleo@gmail.com wrote:
> From: Adrian Marius Negreanu <adrian.m.negreanu@intel.com>
>
> tested by setting ENABLE_NLS to zero, inside config.h
Thanks - note you can use ./configure --disable-nls for the same effect.
> --- a/parse.cxx
> +++ b/parse.cxx
> @@ -592,7 +592,7 @@ parser::scan_pp1 ()
> if (! (t && t->type == tok_operator && t->content == "("))
> {
> delete new_act;
> - throw parse_error (_F(ngettext
> + throw parse_error (_F(_N
> ("expected '(' in invocation of macro '@%s'"
> " taking %d parameter",
> "expected '(' in invocation of macro '@%s'"
Eww, example like this are attempting to double-translate, regardless of
your change. We have _NF(format, format_plural, count, ...) which
should handle this correctly.
If you could correct those, then the rest of it looks fine to me.
Thanks,
Josh
More information about the Systemtap
mailing list