[Bug tapsets/14690] the syscall tapsets could be written to prefer the 'syscalls' tracepoints

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14690

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

--- Comment #1 from Josh Stone <jistone at redhat dot com> 2012-10-09 20:14:12 UTC ---
(In reply to comment #0)
> probe syscall.access = kernel.trace("sys_enter_access") !,
>       kernel.function("sys_access").call
> {
>   # ... we'd probably need to use @defined() to get the correct arguments
> }

IMO, when we already know what variables should be used in which probe point,
it's better to split the aliases than use @defined, e.g.

probe syscall.access = tp_syscall.access!, kp_syscall.access
{ /* common stuff */ }
probe tp_syscall.access = kernel.trace("sys_enter_access")
{ /* tracepoint specifics */ }
probe kp_syscall.access = kernel.function("sys_access").call
{ /* kprobe specifics */ }

We might even choose to unify nd_syscall.access in there too.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.