[PATCH v3 2.6.39-rc1-tip 15/26] 15: uprobes: Handing int3 and singlestep exception.
Steven Rostedt
rostedt@goodmis.org
Tue Apr 19 13:12:00 GMT 2011
On Tue, 2011-04-19 at 15:03 +0200, Peter Zijlstra wrote:
> On Fri, 2011-04-01 at 20:05 +0530, Srikar Dronamraju wrote:
> > + if (unlikely(!utask)) {
> > + utask = add_utask();
> > +
> > + /* Failed to allocate utask for the current task. */
> > + BUG_ON(!utask);
>
> That's not really nice is it ;-) means I can make the kernel go BUG by
> simply applying memory pressure.
Agreed,
None of these patches should have a single BUG_ON(). They all must fail
nicely.
-- Steve
>
> > + utask->state = UTASK_BP_HIT;
> > + }
More information about the Systemtap
mailing list