[PATCH v2 2.6.38-rc8-tip 7/20] 7: uprobes: store/restore original instruction.

[Steven Rostedt]

On Tue, 2011-03-15 at 14:52 +0530, Srikar Dronamraju wrote:
> * Stephen Wilson <wilsons@start.ca> [2011-03-14 14:09:14]:
> 

Nitpick:

> Guess checking for tsk != NULL would only help if and only if we are doing
> within rcu.  i.e we have to change to something like this
> 

	tsk = NULL;

> 	rcu_read_lock()
> 	if (mm->owner) {
> 		get_task_struct(mm->owner)
> 		tsk = mm->owner;
> 	}
> 	rcu_read_unlock()
> 	if (!tsk)
> 		return ret;
> 
> Agree?

Or:

	rcu_read_lock();
	tsk = mm->owner;
	if (tsk)
		get_task_struct(tsk);
	rcu_read_unlock();
	if (!tsk)
		return ret;

Probably looks cleaner.

-- Steve