[RFC] [PATCH 2.6.37-rc5-tip 5/20] 5: Uprobes: register/unregister probes.
Peter Zijlstra
peterz@infradead.org
Thu Jan 27 10:40:00 GMT 2011
On Thu, 2011-01-27 at 15:55 +0530, Srikar Dronamraju wrote:
>
>
> If its not at the exact same location, then our third validation of
> checking that (vaddr == vma->vm_start + uprobe->offset) should fail
> right?
>
> Also should it be (vaddr == uprobe->offset + vma->vm_start -
> vma->pgoff << PAGE_SHIFT) ?
Yeah, although I just realized that ->offset should be a u64, since
pgoff is a unsigned long, we can have files up to 44 bit (assuming the
page-size is 12bits).
But yes, this matches the validation I mentioned.
More information about the Systemtap
mailing list