[PATCH -tip 10/10] perf probe: Accessing members in data structures

[Mark Wielaard]

On Tue, 2010-03-16 at 18:06 -0400, Masami Hiramatsu wrote:
> Support accessing members in the data structures. With this,
> perf-probe accepts data-structure members(IOW, it now accepts
> dot '.' and arrow '->' operators) as probe arguemnts.
> 
> e.g.
> 
>  ./perf probe --add 'schedule:44 rq->curr'
> 
>  ./perf probe --add 'vfs_read file->f_op->read file->f_path.dentry'
> 
> Note that '>' can be interpreted as redirection in command-line.

If you find that a problem then you can do like SystemTap does and allow
'.' in place of '->'. In the code you already use the
perf_probe_arg_field ref flag only to check that the DIE gives you the
same information. So you could just drop that and use any separator.
Then you decide based on whether you see a DW_TAG_pointer_type. This
gives the user some extra flexibility by letting them not having to care
about specifying extra type information already available elsewhere.

Cheers,

Mark