[PATCH] Update SCSI tapset

Andre Detsch adetsch@br.ibm.com
Wed Dec 23 18:57:00 GMT 2009


Frank Ch. Eigler wrote:
> Andre Detsch <adetsch@br.ibm.com> writes:
> 
>> This patch updates the scsi.stp tapset, as long as the
>> correspondent testcase. [...]
> Looks good to me.  Is the existing scsi-related example (iostat-scsi)
>  a sufficient showcase of this tapset?

iostat-scsi example does not use the scsi.stp tapset. It references the 
kernel functions directly, and is focused on scsi disk and tape (sd_*, st_*).

scsi.stp probes, on the other hand, are related to more generic mid-layer SCSI
calls. Currently, the only usage example is "testsuite/buildok/scsi.stp". It 
covers all tapsets/scsi.stp probes. If it is good to have something inside
testsuite/systemtap.examples/io/, maybe moving or copying content from 
testsuite/buildok/scsi.stp, I can provide a patch.

-- 
André Detsch
Kernel Software Engineer - Network Device Drivers
Linux Technology Center Brazil



More information about the Systemtap mailing list