[PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency
Roland McGrath
roland@redhat.com
Fri Nov 13 23:16:00 GMT 2009
To clarify, proc_coredump_filter_write() is the one place that can change
mm->flags during a core dump. I don't think any other is possible while
all the other tasks sharing that mm are prevented from running. Is there
any other way that mm->flags might change during do_coredump()?
I don't see anything wrong with this change. But (assuming that is the
only case), there is another approach we could take instead. That is,
have proc_coredump_filter_write() do:
down_read(&mm->mmap_sem);
ret = mm->core_state ? -EBUSY : 0;
up_read(&mm->mmap_sem);
Thanks,
Roland
More information about the Systemtap
mailing list