[Bug kprobes/10869] kretprobes waste a lot of memory on kretprobe_instances
Jim Keniston
jkenisto@us.ibm.com
Fri Oct 30 12:43:00 GMT 2009
Quoting ananth at in dot ibm dot com <sourceware-bugzilla@sourceware.org>:
>
> ------- Additional Comments From ananth at in dot ibm dot com
> 2009-10-30 07:29 -------
> Created an attachment (id=4344)
> --> (http://sourceware.org/bugzilla/attachment.cgi?id=4344&action=view)
> Be smarter in allocating kretprobe instances
>
> All along, kretprobes would allocate NR_CPU kretprobe_instance
> structures. Use
> a more logical num_possible_cpus() instead.
>
> If this patch is acceptable, I'll post it upstream.
>
> Jim, Masami?
>
> --
>
>
> http://sourceware.org/bugzilla/show_bug.cgi?id=10869
>
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
Looks good to me.
While you're in that code... the default maxactive for
non-preemptable, non-SMP systems is (still) 1. That's always felt
pretty uncomfortable. But that's a different discussion, and
presumably a different patch.
More information about the Systemtap
mailing list