[PATCH tracing/kprobes v3 4/7] tracing/kprobes: Avoid field name confliction

Masami Hiramatsu mhiramat@redhat.com
Mon Oct 12 19:09:00 GMT 2009


Frederic Weisbecker wrote:
> The conflict issue might not be obvious for a user desperately trying to set
> a kprobe. Even for other failcases, it might not be obvious (blacklisted
> symbols, syntax errors...)
>
> May be should you improve the error granularity and print a KERN_DEBUG
> message?

Agreed, and kprobes error handling should be improved too (in the most cases,
it just returns -EINVAL).

Thank you.

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com



More information about the Systemtap mailing list