On 10/01/2009 10:09 AM, Kiran wrote:
> Hi Josh,
>
> Thanks a lot for your comments. I am sending version 4 of the patch
> incorporating your comments.
Hi Kiran,
This looks good, just one more thing:
> + printf("%s\t\t%d\t%d\t%d:%d:%s + %d:%d:%s %s\n",
> + execname(), task_cpu(task), gettimeofday_ns(),
> + pid(), task_prio(task_current()), state_calc(task_state(task_current())),
> + task_pid(task), task_prio(task), state_calc(task_state(task)),
> + task_execname(task))
> + %)
> + printf("%-16s%5d%5d%d:%d:%s + %d:%d:%s %16s\n",
> + execname(), task_cpu(task), gettimeofday_ns(),
> + pid(), task_prio(task_current()), state_calc(task_state(task_current())),
> + task_pid(task), task_prio(task), state_calc(task_state(task)),
> + task_execname(task))
[...]
> + printf("%-16s%5d%5d%d:%d:%s ==> %d:%d:%s %16s\n",prev_task_name,
> + task_cpu(prev_task),gettimeofday_ns(),prev_pid,prev_priority,state_calc(prevtsk_state),next_pid,
> + next_priority,state_calc(nexttsk_state),next_task_name)
> + %)
> +
> + printf("%-16s%5d%5d%d:%d:%s ==> %d:%d:%s %16s\n",prev_task_name,
> + task_cpu(prev_task),gettimeofday_ns(),prev_pid,prev_priority,state_calc(prevtsk_state),next_pid,
> + next_priority,state_calc(nexttsk_state),next_task_name)
> +}
I'm confused why these printfs are now duplicated; I think only those
outside the '%)' are needed. If you agree, then I'll just remove the
inner printfs and then commit this.
Thanks,
Josh