[PATCH] Correct misnamed and remove superfluous variables in syscalls.stp.
Josh Stone
jistone@redhat.com
Tue May 19 00:17:00 GMT 2009
On 05/18/2009 04:12 PM, Przemyslaw Pawelczyk wrote:
> In syscall.(faccess|fchmod|fchown|link|mknod)at probe points:
> - Rename variables accordingly to argument names used in man pages.
This much is good.
> - Remove string-formatted integer variables.
I don't agree with this part though, because those string variables are
providing a non-trivial conversion using undocumented functions
(prefixed with '_'). I think that's valuable to have, and it doesn't
hurt anything for scripts that don't use them.
Josh
More information about the Systemtap
mailing list