[PATCH -rc] [BUGFIX] x86: fix kernel_trap_sp()

Linus Torvalds torvalds@linux-foundation.org
Tue May 12 14:43:00 GMT 2009



On Tue, 12 May 2009, Robin Holt wrote:
> >   */
> > -static inline unsigned long kernel_trap_sp(struct pt_regs *regs)
> > +static inline unsigned long kernel_stack_pointer(struct pt_regs *regs)
> 
> Why not have it return an unsigned long *?

I considered it, but since part of the point of the patch was to make it 
look like the mirror of "user_stack_pointer()", returning "unsigned long" 
looked more appropriate.

But I have no really strong opinions. I wouldn't object to making it 
return "unsigned long *" either.

		Linus



More information about the Systemtap mailing list