[Bug translator/10054] improve $expr->foo->bar->zoo error messages

[jistone at redhat dot com]

------- Additional Comments From jistone at redhat dot com  2009-04-16 16:20 -------
(In reply to comment #1)
> Created an attachment (id=3887)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3887&action=view)
> first stage patch
> 
> With the patch,  the correct local variable  name will be focused instead of
> top one.
[...]
> 'foo' replaces the previous 'file'.  And the remains parts are "identifier
> $file" and the position of "^".  Seems not easy to change them since they are
> from e->tok.

This is a good first step.  However, I would rather see an error "unable to find
member ..." generated at the point of failure.  We should just make the mode of
translate_components be succeed-or-throw, and then the callers can be simpler.

For getting the right token, I would suggest changing the components vector's
element-type into a real struct (instead of just a std::pair), and then the
parsing token can be saved there.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10054

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.