[PATCH] itrace spin lock fix

[Dave Nomura]

I merged your patch in with mine and fixed the ChangeLog entry.

David Smith wrote:
> Dave Nomura wrote:
>   
>> Back in August Frank reported a problem running the itrace test on an
>> x86-64 machine.  This was caused by an uninitialized spin_lock and
>> possibly by some utrace callouts that didn't need in the spin_lock
>> protected regions.  This patch fixes that problem.
>>     
>
> Your patch's ChangeLog is wrong.  You should put the entry in
> src/runtime/ChangeLog, not src/ChangeLog.
>
> I ran this patch on a RHEL5 x86_64 (2.6.18-92.1.13.el5debug) machine.
> Systemtap couldn't compile modules without the following small patch:
>
> diff --git a/tapsets.cxx b/tapsets.cxx
>
> index bed2796..057a554 100644
>
> --- a/tapsets.cxx
>
> +++ b/tapsets.cxx
>
> @@ -5778,6 +5778,7 @@ itrace_derived_probe_group::emit_module_decls
> (systemtap_\
> session& s)
>
>
>
>    s.op->newline();
>
>    s.op->newline() << "/* ---- itrace probes ---- */";
>
> +  s.op->newline() << "#include \"task_finder.c\"";
>
>    s.op->newline() << "struct stap_itrace_probe {";
>
>    s.op->indent(1);
>
>    s.op->newline() << "struct stap_task_finder_target tgt;";
>
> With the above patch, systemtap could compile modules again.  The
> itrace.exp test script ran (with the early exit deleted), but failed
> because the itrace probes never got hit.
>
>   


-- 
Dave Nomura
LTC Linux Power Toolchain

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: itrace_spin_lock.patch
URL: <http://sourceware.org/pipermail/systemtap/attachments/20081025/5be04a3f/attachment.ksh>