[PATCH 3/3] PR4886: Check build-id in module_init function if able.
Elena Zannoni
elena.zannoni@oracle.com
Tue Sep 30 16:29:00 GMT 2008
Thanks for the review, Frank.
Wenji is out this week, for the Chinese National holiday. He'll check it
in when he gets back.
elena
Frank Ch. Eigler wrote:
> Hi, Wenji -
>
> Excellent work. If it passes regression tests, please check it in.
> It shouldn't be hard to apply it to userspace too, if it doesn't
> already just work.
>
> Some tweaks to the various messages may be helpful later, such as to
> print parts of the buildid strings for eyeballing by the user, but
> otherwise it looks just fine.
>
> - FChE
>
>
--
Elena Zannoni, Oracle
Senior Engineering Manager, Tools/Languages - Linux Engineering
Blog: http://blogs.oracle.com/ezannoni
Email: elena.zannoni@oracle.com
More information about the Systemtap
mailing list