[PATCH 1/2] marker probe: $name support (Re: [RFC] sample test script and tapset for markers)

Frank Ch. Eigler fche@redhat.com
Fri Sep 5 16:19:00 GMT 2008


Hi -

On Fri, Sep 05, 2008 at 11:32:24AM -0400, Masami Hiramatsu wrote:
> Here is a patch which add $name variable access from marker probe.
> I added _stp_mark_context structure which contains .name and .format
> strings for passing both of them to marker handler. [...]

That seems unnecessary.  You could have added the name/format as
separate fields, and have the embedded-C functions use
CONTEXT->marker_name / marker_format.  (Those fields then better be
cleared to zero for other types of probes, and the embedded-C code
better check for that.)


- FChE



More information about the Systemtap mailing list