unsafe in _stp_init_kernel_symbols

Wenji Huang wenji.huang@oracle.com
Tue Jun 17 15:21:00 GMT 2008


HI,

I think it's not safe in function _stp_init_kernel_symbols(). The kernel 
symbols is from
          _stp_modules[0]->symbols = _stp_kernel_symbols;

But _stp_kernel_symbols is from debuginfo file or /proc/kallsyms.

The function is executed in running time. Maybe the runnning kernel 
doesn't match the debuginfo. The kernel symbols are incorrect.

So there will be danger of kernel oops. for example in such statement:

     /* Use the seq_file interface to safely get a list of installed 
modules */
     res = modules_op->start(NULL, &pos);

Regards,
Wenji








More information about the Systemtap mailing list