Bug: duplicate marker entry in Modules.marker

Wenji Huang wenji.huang@oracle.com
Thu Mar 20 09:02:00 GMT 2008


The marker maybe has same name, but different format.

Roland McGrath wrote:
> Sorry, should have been (?):
> 
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 695b5d6..ca8015d 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1973,7 +1973,8 @@ static void read_markers(const char *fname)
>  			mod->skip = 1;
>  		}
>  
> -		add_marker(mod, marker, fmt);
> +		if (mod->skip)
> +			add_marker(mod, marker, fmt);
>  	}

Good solution, it's OK in case of modules, but vmlinux. I just defined 
marker in built-in code and changed it.
Still two entries.
I guess the above modification together with emptying the file before 
run of modpost for vmlinux
will solve the problem.

Regards,
Wenji



More information about the Systemtap mailing list