[PATCH][Cleanup] testsuite cleanup patches

Masami Hiramatsu mhiramat@redhat.com
Wed Feb 6 16:33:00 GMT 2008


Hi,

I found that testsuite failed to cleanup some temporary files.
Here are 3 patches which fix following issues.

1. Bulk output files created by systemtap.printf/*b.exp are not erased.
  Basically, this issue was caused by passing local variables to as_root.

- testsuite-cleanup-tmpfile.patch fixes this issue by passing evaluated
 command string to as_root.


2. PROCFS.ko created by systemtap.base/procfs.exp is not erased.

- testsuite-cleanup-procfs.patch erases it at the tail of procfs.exp.


3. systemtap_test_module* created by systemtap.context/context.exp
   are not unloaded nor be erased. Actually, the context.exp has
   its cleanup routine but not uses it.

- testsuite-cleanup-context-testdir.patch invokes the cleanup routine
  at the tail of context.exp.


Here is an unsolved issue:
4. Some /tmp/stapXXXXX directories are not erased. I found one of these
   was created by systemtap.base/debugpath.exp, but there might be other
   scripts which also failed to erase. we need to dig it deeply.

Thanks,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: testsuite-cleanup-tmpfile.patch
Type: text/x-patch
Size: 5950 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/systemtap/attachments/20080206/d7debd87/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testsuite-cleanup-procfs.patch
Type: text/x-patch
Size: 567 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/systemtap/attachments/20080206/d7debd87/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testsuite-cleanup-context-testdir.patch
Type: text/x-patch
Size: 457 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/systemtap/attachments/20080206/d7debd87/attachment-0002.bin>


More information about the Systemtap mailing list